Reserve square bracket syntax for ingest document flexible field access pattern #134172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaiera
added
>non-issue
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine
added
the
Team:Data Management
jbaiera
force-pushed
the
streams-reserve-square-brackets
branch
from
10454cf to
646405a
Compare
masseyke
reviewed
Sep 11, 2025
server/src/main/java/org/elasticsearch/ingest/IngestDocument.java
Outdated
Show resolved
Hide resolved
masseyke
reviewed
Sep 11, 2025
| * @param pathParts The tokenized field path to parse | ||
| * @return An array of Strings | ||
| */ | ||
| private static String[] parseFlexibleFields(String fullPath, String[] pathParts) { |
Member
There was a problem hiding this comment.
Is it meaningful that this is named parseFlexibleFields, when the analogous method for classic mode is validateClassicFields? They're both just validating, right?
Member
Author
There was a problem hiding this comment.
I heavily adapted this code from #133790 with the hope that I can rebase it on top of these changes with minimal heartburn. I think this is just the method name from that PR.
masseyke
reviewed
Sep 11, 2025
server/src/main/java/org/elasticsearch/ingest/IngestDocument.java
Outdated
Show resolved
Hide resolved
masseyke
approved these changes
Sep 11, 2025
Member
masseyke
left a comment
masseyke
left a comment
There was a problem hiding this comment.
I left a few minor questions, but LGTM.
jbaiera
added
the
auto-merge-without-approval
gmjehovich
pushed a commit
to gmjehovich/elasticsearch
that referenced
this pull request
Sep 18, 2025
…ss pattern (elastic#134172) Adds validation to field path parsing to ensure that no square brackets are used in the path when flexible mode is enabled. We plan to introduce array indexing syntax to flexible mode in the future (`a.b[1].c`), but only after it is more widely supported in the ingest node APIs. To ensure that users do not make a habit of using this reserved syntax going forward, we are reserving it to ensure that it remains unused until it is supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds validation to field path parsing to ensure that no square brackets are used in the path when flexible mode is enabled. We plan to introduce array indexing syntax to flexible mode in the future (
a.b[1].c), but only after it is more widely supported in the ingest node APIs. To ensure that users do not make a habit of using this reserved syntax going forward, we are reserving it to ensure that it remains unused until it is supported.